Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] metadata support LRU memory evict strategy in shared-nothing cluster (backport #48832) #49169

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[Enhancement] metadata support LRU memory evict strategy in shared-nothing cluster (backport #48832) #49169

merged 2 commits into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 30, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

In previous implementation, there is no memory limit for metadata in shared-nothing cluster. So if there are too many tablets and segment files, BE will OOM. We need a controllable metadata memory strategy.

What I'm doing:

Add a lru cache for metadata, its capacity is controlled by be.conf metadata_cache_memory_limit_percent.
When Rowset performs a load action, it adds the Rowset to the lru cache, and if the lru cache memory exceeds the limit, it selectively eliminates the loaded Rowset, ultimately realizing the goal of controllable metadata memory.
This strategy is only support non-pk table now.

There will be two cases when evict the Rowset:

  1. There is no reference hold by other user, Rowset's state will change from ROWSET_LOADED to ROWSET_UNLOADED , and then release the memory.
  2. There are reference hold by other user (e.g. compaction or query), Rowset's state will change from ROWSET_LOADED to ROWSET_UNLOADING. Memory will be release after compaction or query finish.

Test Result

image

  1. Before turning on LRU cache control strategy, metadata continues to increase without limit.
  2. After enabling LRU cache control strategy (with limit set to 1GB), metadata memory is stabilized at 1GB.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #48832 done by [Mergify](https://mergify.com). ## Why I'm doing: In previous implementation, there is no memory limit for `metadata` in shared-nothing cluster. So if there are too many tablets and segment files, BE will OOM. We need a controllable `metadata` memory strategy.

What I'm doing:

Add a lru cache for metadata, its capacity is controlled by be.conf metadata_cache_memory_limit_percent.
When Rowset performs a load action, it adds the Rowset to the lru cache, and if the lru cache memory exceeds the limit, it selectively eliminates the loaded Rowset, ultimately realizing the goal of controllable metadata memory.
This strategy is only support non-pk table now.

There will be two cases when evict the Rowset:

  1. There is no reference hold by other user, Rowset's state will change from ROWSET_LOADED to ROWSET_UNLOADED , and then release the memory.
  2. There are reference hold by other user (e.g. compaction or query), Rowset's state will change from ROWSET_LOADED to ROWSET_UNLOADING. Memory will be release after compaction or query finish.

Test Result

image

  1. Before turning on LRU cache control strategy, metadata continues to increase without limit.
  2. After enabling LRU cache control strategy (with limit set to 1GB), metadata memory is stabilized at 1GB.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@luohaha @mergify
[Enhancement] metadata support LRU memory evict strategy in shared-no…
3555668 
…thing cluster (#48832)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0f639ad)

# Conflicts:
#	be/src/storage/CMakeLists.txt
@mergify mergify bot added the conflicts label Jul 30, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 30, 2024

Cherry-pick of 0f639ad has failed:

On branch mergify/bp/branch-3.3/pr-48832
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 0f639ad566.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/common/config.h
	new file:   be/src/storage/rowset/metadata_cache.cpp
	new file:   be/src/storage/rowset/metadata_cache.h
	modified:   be/src/storage/rowset/rowset.cpp
	modified:   be/src/storage/rowset/rowset.h
	modified:   be/src/storage/storage_engine.cpp
	modified:   be/src/storage/tablet_manager.cpp
	modified:   be/src/storage/tablet_manager.h
	modified:   be/src/util/starrocks_metrics.h
	modified:   be/test/CMakeLists.txt
	new file:   be/test/storage/rowset/metadata_cache_test.cpp
	modified:   be/test/storage/tablet_mgr_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/storage/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jul 30, 2024
Merged
24 tasks
@mergify mergify bot closed this Jul 30, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) July 30, 2024 14:54
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 30, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled July 30, 2024 14:54

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-3.3/pr-48832 branch July 30, 2024 14:55
@luohaha luohaha restored the mergify/bp/branch-3.3/pr-48832 branch July 30, 2024 15:14
@luohaha luohaha reopened this Jul 30, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) July 30, 2024 15:15
@luohaha
resolve
96d3e87 
Signed-off-by: Yixin Luo <[email protected]>
@luohaha luohaha disabled auto-merge July 31, 2024 04:59
@luohaha luohaha enabled auto-merge (squash) July 31, 2024 04:59
@luohaha
Copy link
Contributor

luohaha commented Jul 31, 2024

ignore backport check 3.3.2

@luohaha luohaha disabled auto-merge August 8, 2024 15:28
@luohaha luohaha merged commit 2bf72d8 into branch-3.3 Aug 8, 2024
28 of 29 checks passed
@luohaha luohaha deleted the mergify/bp/branch-3.3/pr-48832 branch August 8, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohaha luohaha luohaha approved these changes

Assignees

@luohaha luohaha

Labels
automerge behavior_changed conflicts version:3.3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luohaha